From 0e218a71c432c5b36424dec0526aafe24bb5308a Mon Sep 17 00:00:00 2001
From: notfire <notfire@posteo.net>
Date: Tue, 1 Apr 2025 18:22:28 -0400
Subject: [PATCH] add option to disable showing unreads in the title, also a
 bit of cleanup

---
 README.md                                     |   4 +-
 src/components/notifications/notifications.js |   3 +-
 .../settings_modal/tabs/general_tab.vue       | 122 ++++++++++--------
 src/i18n/en.json                              |   1 +
 src/modules/config.js                         |   1 +
 src/modules/instance.js                       |   1 +
 6 files changed, 73 insertions(+), 59 deletions(-)

diff --git a/README.md b/README.md
index 4ea776d0..8432e0ed 100644
--- a/README.md
+++ b/README.md
@@ -23,7 +23,9 @@
 - filters for reactions:
     - matching by regex, domain-specific, or catch-all
     - filters the actual reactions to post as well as notifications
-- option to disable favicon badge when there's unread notifications
+- for unreads:
+    - option to disable favicon badge changing on unreads
+    - option to disable title showing unreads
 
 ---
 
diff --git a/src/components/notifications/notifications.js b/src/components/notifications/notifications.js
index e78f2c69..84099ed3 100644
--- a/src/components/notifications/notifications.js
+++ b/src/components/notifications/notifications.js
@@ -87,7 +87,8 @@ const Notifications = {
       if (count > 0) {
         if (this.$store.getters.mergedConfig.showFaviconBadge)
           FaviconService.drawFaviconBadge()
-        this.$store.dispatch('setPageTitle', `(${count})`)
+        if (this.$store.getters.mergedConfig.showUnreadInTitle)
+          this.$store.dispatch('setPageTitle', `(${count})`)
       } else {
         FaviconService.clearFaviconBadge()
         this.$store.dispatch('setPageTitle', '')
diff --git a/src/components/settings_modal/tabs/general_tab.vue b/src/components/settings_modal/tabs/general_tab.vue
index e0c63fc7..508f9a1b 100644
--- a/src/components/settings_modal/tabs/general_tab.vue
+++ b/src/components/settings_modal/tabs/general_tab.vue
@@ -709,69 +709,77 @@
     </div>
 
     <div
+      class="setting-item"
       v-if="expertLevel > 0"
     >
-      <div class="setting-item">
-        <h2>{{ $t('settings.requires_refresh') }}</h2>
-        <small>{{ $t('settings.requires_refresh_exp') }}</small>
-        <ul class="setting-list">
-          <li>
-            <BooleanSetting
-              path="autoRefreshOnRequired"
-              expert="1"
-            >
-              {{ $t('settings.auto_refresh_on_required') }}
-            </BooleanSetting>
-          </li>
-          <li>
-            <BooleanSetting
-              path="dedupeBoosts"
-              expert="1"
-              @click="checkAutoReload"
-            >
-              {{ $t('settings.dedupe_boosts') }}
-            </BooleanSetting>
-          </li>
-          <li>
-            <BooleanSetting
-              path="showFaviconBadge"
-              expert="1"
-              @click="checkAutoReload"
-            >
-              {{ $t('settings.show_favicon_badge') }}
-            </BooleanSetting>
-          </li>
-        </ul>
-      </div>
+      <h2>{{ $t('settings.requires_refresh') }}</h2>
+      <small>{{ $t('settings.requires_refresh_exp') }}</small>
+      <ul class="setting-list">
+        <li>
+          <BooleanSetting
+            path="autoRefreshOnRequired"
+            expert="1"
+          >
+            {{ $t('settings.auto_refresh_on_required') }}
+          </BooleanSetting>
+        </li>
+        <li>
+          <BooleanSetting
+            path="dedupeBoosts"
+            expert="1"
+            @click="checkAutoReload"
+          >
+            {{ $t('settings.dedupe_boosts') }}
+          </BooleanSetting>
+        </li>
+        <li>
+          <BooleanSetting
+            path="showFaviconBadge"
+            expert="1"
+            @click="checkAutoReload"
+          >
+            {{ $t('settings.show_favicon_badge') }}
+          </BooleanSetting>
+        </li>
+        <li>
+          <BooleanSetting
+            path="showUnreadInTitle"
+            expert="1"
+            @click="checkAutoReload"
+          >
+            {{ $t('settings.show_unread_in_title') }}
+          </BooleanSetting>
+        </li>
+      </ul>
     </div>
+
     <div
+      class="setting-item"
       v-if="this.$store.getters.mergedConfig.sillyFeatures"
     >
-      <div class="setting-item">
-        <h2>{{ $t('settings.silly_features') }}</h2>
-        <ul class="setting-list">
-          <li>
-            <BooleanSetting
-              path="recurseSearch"
-            >
-              {{ $t('settings.recurse_search') }}
-            </BooleanSetting>
-            <ul
-            class="setting-list suboptions"
-            :class="[{disabled: !recurseSearch}]"
-            >
-              <li>
-                <IntegerSetting
-                  path="recurseSearchLimit"
-                  :min="100"
-                >
-                  {{ $t('settings.recurse_search_limit') }}
-                </IntegerSetting>
-              </li>
-            </ul>
-          </li>
-        </ul>
-      </div>
+      <h2>{{ $t('settings.silly_features') }}</h2>
+      <ul class="setting-list">
+        <li>
+          <BooleanSetting
+            path="recurseSearch"
+          >
+            {{ $t('settings.recurse_search') }}
+          </BooleanSetting>
+          <ul
+          class="setting-list suboptions"
+          :class="[{disabled: !recurseSearch}]"
+          >
+            <li>
+              <IntegerSetting
+                path="recurseSearchLimit"
+                :min="100"
+              >
+                {{ $t('settings.recurse_search_limit') }}
+              </IntegerSetting>
+            </li>
+          </ul>
+        </li>
+      </ul>
     </div>
   </div>
 </template>
diff --git a/src/i18n/en.json b/src/i18n/en.json
index 10116639..59e50515 100644
--- a/src/i18n/en.json
+++ b/src/i18n/en.json
@@ -784,6 +784,7 @@
         "show_panel_nav_shortcuts": "Show timeline navigation shortcuts at the top of the panel",
         "show_scrollbars": "Show side column's scrollbars",
         "show_page_backgrounds": "Show page-specific backgrounds, e.g. for user profiles",
+        "show_unread_in_title": "Show (x) in title for unread notifications",
         "show_wider_shortcuts": "Show wider gap between top panel shortcuts",
         "show_yous": "Show (You)s",
         "silly_features": "Silly features",
diff --git a/src/modules/config.js b/src/modules/config.js
index 5a558973..1506b06a 100644
--- a/src/modules/config.js
+++ b/src/modules/config.js
@@ -130,6 +130,7 @@ export const defaultState = {
   dedupeBoosts: true,
   showFaviconBadge: true,
   autoRefreshOnRequired: true,
+  showUnreadInTitle: true,
   renderMisskeyMarkdown: undefined,
   renderMfmOnHover: undefined, // instance default
   conversationDisplay: undefined, // instance default
diff --git a/src/modules/instance.js b/src/modules/instance.js
index a4fbc6ad..75dd6aa7 100644
--- a/src/modules/instance.js
+++ b/src/modules/instance.js
@@ -86,6 +86,7 @@ const defaultState = {
   dedupeBoosts: true,
   showFaviconBadge: true,
   autoRefreshOnRequired: true,
+  showUnreadInTitle: true,
   renderMisskeyMarkdown: true,
   renderMfmOnHover: false,
   conversationDisplay: 'linear',