notfire/Iceshrimp.NET
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Update TODOs

Browse source
This commit is contained in:
Laura Hausmann 2024-01-24 04:16:13 +01:00
parent f15fd9cc79
commit de3ca32aa9
No known key found for this signature in database
GPG key ID: D044E84C5BE01605
1 changed files with 2 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
Iceshrimp.Backend/Core/Middleware/ErrorHandlerMiddleware.cs
View file

@ -30,6 +30,7 @@ public class ErrorHandlerMiddleware(RequestDelegate next) {
Message = e.Message, Message = e.Message,
RequestId = ctx.TraceIdentifier RequestId = ctx.TraceIdentifier
}); });
//TODO: use the overload that takes an exception instead of printing it ourselves
logger.LogError("Request {id} encountered an unexpected error: {exception}", ctx.TraceIdentifier, logger.LogError("Request {id} encountered an unexpected error: {exception}", ctx.TraceIdentifier,
e.ToString()); e.ToString());
} }
@ -38,6 +39,7 @@ public class ErrorHandlerMiddleware(RequestDelegate next) {
} }
//TODO: Find a better name for this class //TODO: Find a better name for this class
//TODO: is there a better way to resolve the originating class than passing the logger? Maybe CustomException<T>, or reflection
public class CustomException(HttpStatusCode statusCode, string error, string message, ILogger? logger) public class CustomException(HttpStatusCode statusCode, string error, string message, ILogger? logger)
: Exception(message) { : Exception(message) {
public readonly string Error = error; public readonly string Error = error;