notfire/Iceshrimp.NET
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

[backend/signalr] Catch exceptions in event handlers to prevent exceptions from causing backend crashes

Browse source
This commit is contained in:
Laura Hausmann 2024-11-20 00:45:49 +01:00
parent 004af22b68
commit c91a1fa8bc
No known key found for this signature in database
GPG key ID: D044E84C5BE01605
1 changed files with 27 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

33
Iceshrimp.Backend/SignalR/Helpers/StreamingConnectionAggregate.cs
View file

@ -418,20 +418,41 @@ public sealed class StreamingConnectionAggregate : IDisposable
private async void OnFilterAdded(object? _, Filter filter)
{
if (filter.User.Id != _userId) return;
await _hub.Clients.User(_userId).FilterAddedAsync(FilterRenderer.RenderOne(filter));
try
{
if (filter.User.Id != _userId) return;
await _hub.Clients.User(_userId).FilterAddedAsync(FilterRenderer.RenderOne(filter));
}
catch (Exception e)
{
_logger.LogError("Event handler {handler} threw exception: {e}", nameof(OnFilterAdded), e);
}
}
private async void OnFilterUpdated(object? _, Filter filter)
{
if (filter.User.Id != _userId) return;
await _hub.Clients.User(_userId).FilterUpdatedAsync(FilterRenderer.RenderOne(filter));
try
{
if (filter.User.Id != _userId) return;
await _hub.Clients.User(_userId).FilterUpdatedAsync(FilterRenderer.RenderOne(filter));
}
catch (Exception e)
{
_logger.LogError("Event handler {handler} threw exception: {e}", nameof(OnFilterUpdated), e);
}
}
private async void OnFilterRemoved(object? _, Filter filter)
{
if (filter.User.Id != _userId) return;
await _hub.Clients.User(_userId).FilterRemovedAsync(filter.Id);
try
{
if (filter.User.Id != _userId) return;
await _hub.Clients.User(_userId).FilterRemovedAsync(filter.Id);
}
catch (Exception e)
{
_logger.LogError("Event handler {handler} threw exception: {e}", nameof(OnFilterRemoved), e);
}
}
#endregion