notfire/Iceshrimp.NET
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

[backend/asp] Add Vary: Accept to routes with MediaTypeRouteFilterAttribute

Browse source
This commit is contained in:
Laura Hausmann 2024-04-27 20:29:53 +02:00
parent a20d50f793
commit a70b493188
No known key found for this signature in database
GPG key ID: D044E84C5BE01605
1 changed files with 4 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
Iceshrimp.Backend/Controllers/Attributes/MediaTypeRouteFilterAttribute.cs
View file

@ -1,5 +1,6 @@
using System.Net.Http.Headers; using System.Net.Http.Headers;
using Microsoft.AspNetCore.Mvc.ActionConstraints; using Microsoft.AspNetCore.Mvc.ActionConstraints;
using Microsoft.Net.Http.Headers;
namespace Iceshrimp.Backend.Controllers.Attributes; namespace Iceshrimp.Backend.Controllers.Attributes;
@ -8,6 +9,9 @@ public class MediaTypeRouteFilterAttribute(params string[] mediaTypes) : Attribu
{ {
public bool Accept(ActionConstraintContext context) public bool Accept(ActionConstraintContext context)
{ {
// Add Vary: Accept to the response headers to prevent caches serving the wrong response
context.RouteContext.HttpContext.Response.Headers.Append(HeaderNames.Vary, HeaderNames.Accept);
if (!context.RouteContext.HttpContext.Request.Headers.ContainsKey("Accept")) return false; if (!context.RouteContext.HttpContext.Request.Headers.ContainsKey("Accept")) return false;
var accept = context.RouteContext.HttpContext.Request.Headers.Accept.ToString() var accept = context.RouteContext.HttpContext.Request.Headers.Accept.ToString()