notfire/Iceshrimp.NET
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

[backend/queue] Clear change tracker before saving the job state

Browse source 
This prevents a queue worker stall when a job fails to execute due to a database exception (leaving unsaved changes in the DbContext change tracker, preventing the job status from being set as failed)
This commit is contained in:
Laura Hausmann 2024-04-15 17:43:21 +02:00
parent aec5fa2698
commit 8fb7c8a93e
No known key found for this signature in database
GPG key ID: D044E84C5BE01605
1 changed files with 2 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
Iceshrimp.Backend/Core/Services/QueueService.cs
View file

@ -460,6 +460,7 @@ public class PostgresJobQueue<T>(
logger.LogTrace("Job in queue {queue} was delayed to {time} after {duration} ms, has been queued since {time}", logger.LogTrace("Job in queue {queue} was delayed to {time} after {duration} ms, has been queued since {time}",
name, job.DelayedUntil.Value.ToLocalTime().ToStringIso8601Like(), job.Duration, name, job.DelayedUntil.Value.ToLocalTime().ToStringIso8601Like(), job.Duration,
job.QueuedAt.ToLocalTime().ToStringIso8601Like()); job.QueuedAt.ToLocalTime().ToStringIso8601Like());
db.ChangeTracker.Clear();
db.Update(job); db.Update(job);
await db.SaveChangesAsync(token); await db.SaveChangesAsync(token);
await RaiseJobDelayedEvent(db); await RaiseJobDelayedEvent(db);
@ -484,6 +485,7 @@ public class PostgresJobQueue<T>(
} }
} }
db.ChangeTracker.Clear();
db.Update(job); db.Update(job);
await db.SaveChangesAsync(token); await db.SaveChangesAsync(token);