notfire/Iceshrimp.NET
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

[backend/core] Allow 0 & 1 as stand-ins for true & false during model binding (ISH-180)

Browse source
This commit is contained in:
Laura Hausmann 2024-03-13 05:50:39 +01:00
parent d4fe223552
commit 80da86897f
No known key found for this signature in database
GPG key ID: D044E84C5BE01605
1 changed files with 40 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

40
Iceshrimp.Backend/Core/Extensions/ModelBinderProviderExtensions.cs
View file

@ -24,9 +24,11 @@ public static class ModelBinderProviderExtensions
var hybridProvider = new HybridModelBinderProvider(bodyProvider, complexProvider, dictionaryProvider); var hybridProvider = new HybridModelBinderProvider(bodyProvider, complexProvider, dictionaryProvider);
var customCollectionProvider = new CustomCollectionModelBinderProvider(collectionProvider); var customCollectionProvider = new CustomCollectionModelBinderProvider(collectionProvider);
var intToBoolProvider = new IntToBoolModelBinderProvider();
providers.Insert(0, hybridProvider); providers.Insert(0, hybridProvider);
providers.Insert(1, customCollectionProvider); providers.Insert(1, customCollectionProvider);
providers.Insert(2, intToBoolProvider);
} }
} }
@ -52,6 +54,44 @@ public class HybridModelBinderProvider(
} }
} }
public class IntToBoolModelBinderProvider : IModelBinderProvider
{
public IModelBinder? GetBinder(ModelBinderProviderContext context)
{
var isBool = context.Metadata.ModelType.IsAssignableFrom(typeof(bool));
var isNullableBool = context.Metadata.ModelType.IsAssignableFrom(typeof(bool?));
if (!isBool && !isNullableBool) return null;
return new IntToBoolModelBinder();
}
}
public class IntToBoolModelBinder : IModelBinder
{
public Task BindModelAsync(ModelBindingContext bindingContext)
{
var valueProviderResult = bindingContext.ValueProvider.GetValue(bindingContext.ModelName);
var value = valueProviderResult.FirstValue;
var error = $"{bindingContext.ModelName} must be one of: [true, false, 1, 0].";
if (bool.TryParse(value, out var boolValue))
{
bindingContext.Result = ModelBindingResult.Success(boolValue);
}
else if (int.TryParse(value, out var intValue))
{
if (intValue is 0 or 1) bindingContext.Result = ModelBindingResult.Success(intValue != 0);
else bindingContext.ModelState.TryAddModelError(bindingContext.ModelName, error);
}
else if (bindingContext.ModelMetadata.IsNullableValueType && value != null && string.IsNullOrWhiteSpace(value))
{
bindingContext.Result = ModelBindingResult.Success(null);
}
return Task.CompletedTask;
}
}
public class CustomCollectionModelBinderProvider(IModelBinderProvider provider) : IModelBinderProvider public class CustomCollectionModelBinderProvider(IModelBinderProvider provider) : IModelBinderProvider
{ {
public IModelBinder? GetBinder(ModelBinderProviderContext context) public IModelBinder? GetBinder(ModelBinderProviderContext context)