notfire/Iceshrimp.NET
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

[backend/core] Improve poll voter count fallback

Browse source 
This should fix erroneous voter counts for polls from instances that don't return as:votersCount.
This commit is contained in:
Laura Hausmann 2024-10-16 22:07:26 +02:00
parent d625a34e2a
commit 6f55afe60a
No known key found for this signature in database
GPG key ID: D044E84C5BE01605
1 changed files with 11 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
Iceshrimp.Backend/Core/Services/NoteService.cs
View file

@ -623,12 +623,20 @@ public class NoteService(
note.Poll.Votes = poll.Votes == null! || poll.Votes.Count != poll.Choices.Count note.Poll.Votes = poll.Votes == null! || poll.Votes.Count != poll.Choices.Count
? poll.Choices.Select(_ => 0).ToList() ? poll.Choices.Select(_ => 0).ToList()
: poll.Votes; : poll.Votes;
note.Poll.VotersCount = poll.VotersCount ?? note.Poll.VotersCount; note.Poll.VotersCount =
poll.VotersCount ??
(note.Poll.VotersCount == null
? null
: Math.Max(note.Poll.VotersCount.Value, note.Poll.Votes.Sum()));
} }
else if (poll.Votes.Count == poll.Choices.Count) else if (poll.Votes.Count == poll.Choices.Count)
{ {
note.Poll.Votes = poll.Votes; note.Poll.Votes = poll.Votes;
note.Poll.VotersCount = poll.VotersCount ?? note.Poll.VotersCount; note.Poll.VotersCount =
poll.VotersCount ??
(note.Poll.VotersCount == null
? null
: Math.Max(note.Poll.VotersCount.Value, note.Poll.Votes.Sum()));
} }
} }
else else