notfire/Iceshrimp.NET
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

[backend/api] Use SuppressMessage attribute instead of pragma warning disable

Browse source
This commit is contained in:
pancakes 2025-01-22 23:39:32 +10:00 • committed by Laura Hausmann
parent 805393b3e5
commit 59c26686e4
No known key found for this signature in database
GPG key ID: D044E84C5BE01605
1 changed files with 4 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
Iceshrimp.Backend/Controllers/Web/DriveController.cs
View file

@ -1,3 +1,4 @@
using System.Diagnostics.CodeAnalysis;
using System.Net; using System.Net;
using System.Net.Mime; using System.Net.Mime;
using Iceshrimp.Backend.Controllers.Shared.Attributes; using Iceshrimp.Backend.Controllers.Shared.Attributes;
@ -276,6 +277,7 @@ public class DriveController(
[Authorize] [Authorize]
[ProducesResults(HttpStatusCode.OK)] [ProducesResults(HttpStatusCode.OK)]
[ProducesErrors(HttpStatusCode.BadRequest, HttpStatusCode.NotFound, HttpStatusCode.Conflict)] [ProducesErrors(HttpStatusCode.BadRequest, HttpStatusCode.NotFound, HttpStatusCode.Conflict)]
[SuppressMessage("Performance", "CA1862", Justification = "string.Equals() cannot be used in DbSet LINQ operations")]
public async Task<DriveFolderResponse> CreateFolder(DriveFolderRequest request) public async Task<DriveFolderResponse> CreateFolder(DriveFolderRequest request)
{ {
var user = HttpContext.GetUserOrFail(); var user = HttpContext.GetUserOrFail();
@ -284,9 +286,7 @@ public class DriveController(
throw GracefulException.BadRequest("Folder name cannot be empty"); throw GracefulException.BadRequest("Folder name cannot be empty");
var existing = await db.DriveFolders var existing = await db.DriveFolders
#pragma warning disable CA1862
.AnyAsync(p => p.Name.ToLower() == request.Name.Trim().ToLower() .AnyAsync(p => p.Name.ToLower() == request.Name.Trim().ToLower()
#pragma warning restore CA1862
&& p.ParentId == request.ParentId && p.ParentId == request.ParentId
&& p.UserId == user.Id); && p.UserId == user.Id);
if (existing) if (existing)
@ -359,6 +359,7 @@ public class DriveController(
[Authorize] [Authorize]
[ProducesResults(HttpStatusCode.OK)] [ProducesResults(HttpStatusCode.OK)]
[ProducesErrors(HttpStatusCode.BadRequest, HttpStatusCode.NotFound, HttpStatusCode.Conflict)] [ProducesErrors(HttpStatusCode.BadRequest, HttpStatusCode.NotFound, HttpStatusCode.Conflict)]
[SuppressMessage("Performance", "CA1862", Justification = "string.Equals() cannot be used in DbSet LINQ operations")]
public async Task<DriveFolderResponse> UpdateFolder(string id, [FromHybrid] string name) public async Task<DriveFolderResponse> UpdateFolder(string id, [FromHybrid] string name)
{ {
var user = HttpContext.GetUserOrFail(); var user = HttpContext.GetUserOrFail();
@ -371,9 +372,7 @@ public class DriveController(
?? throw GracefulException.RecordNotFound(); ?? throw GracefulException.RecordNotFound();
var existing = await db.DriveFolders var existing = await db.DriveFolders
#pragma warning disable CA1862
.AnyAsync(p => p.Name.ToLower() == name.Trim().ToLower() .AnyAsync(p => p.Name.ToLower() == name.Trim().ToLower()
#pragma warning restore CA1862
&& p.ParentId == folder.ParentId && p.ParentId == folder.ParentId
&& p.UserId == user.Id); && p.UserId == user.Id);
if (existing) if (existing)
@ -418,6 +417,7 @@ public class DriveController(
[Authorize] [Authorize]
[ProducesResults(HttpStatusCode.OK)] [ProducesResults(HttpStatusCode.OK)]
[ProducesErrors(HttpStatusCode.BadRequest, HttpStatusCode.NotFound, HttpStatusCode.Conflict)] [ProducesErrors(HttpStatusCode.BadRequest, HttpStatusCode.NotFound, HttpStatusCode.Conflict)]
[SuppressMessage("Performance", "CA1862", Justification = "string.Equals() cannot be used in DbSet LINQ operations")]
public async Task<DriveFolderResponse> UpdateFolderParent(string id, DriveMoveRequest request) public async Task<DriveFolderResponse> UpdateFolderParent(string id, DriveMoveRequest request)
{ {
var user = HttpContext.GetUserOrFail(); var user = HttpContext.GetUserOrFail();
@ -438,9 +438,7 @@ public class DriveController(
} }
var existing = await db.DriveFolders var existing = await db.DriveFolders
#pragma warning disable CA1862
.AnyAsync(p => p.Name.ToLower() == folder.Name.ToLower() .AnyAsync(p => p.Name.ToLower() == folder.Name.ToLower()
#pragma warning restore CA1862
&& p.ParentId == request.FolderId && p.ParentId == request.FolderId
&& p.UserId == user.Id); && p.UserId == user.Id);
if (existing) if (existing)