[backend/api] Return empty string instead of null when getting avatar, banner, or display name

This commit is contained in:
pancakes 2024-11-27 23:59:21 +10:00 committed by Laura Hausmann
parent 458bb301b3
commit 482172b8e9
No known key found for this signature in database
GPG key ID: D044E84C5BE01605

View file

@ -74,10 +74,10 @@ public class ProfileController(UserService userSvc, DriveService driveSvc) : Con
[HttpGet("avatar")] [HttpGet("avatar")]
[ProducesResults(HttpStatusCode.OK)] [ProducesResults(HttpStatusCode.OK)]
public string? GetAvatarUrl() public string GetAvatarUrl()
{ {
var user = HttpContext.GetUserOrFail(); var user = HttpContext.GetUserOrFail();
return user.AvatarUrl; return user.AvatarUrl ?? "";
} }
[HttpPost("avatar")] [HttpPost("avatar")]
@ -131,10 +131,10 @@ public class ProfileController(UserService userSvc, DriveService driveSvc) : Con
[HttpGet("banner")] [HttpGet("banner")]
[ProducesResults(HttpStatusCode.OK)] [ProducesResults(HttpStatusCode.OK)]
public string? GetBannerUrl() public string GetBannerUrl()
{ {
var user = HttpContext.GetUserOrFail(); var user = HttpContext.GetUserOrFail();
return user.BannerUrl; return user.BannerUrl ?? "";
} }
[HttpPost("banner")] [HttpPost("banner")]
@ -188,10 +188,10 @@ public class ProfileController(UserService userSvc, DriveService driveSvc) : Con
[HttpGet("display_name")] [HttpGet("display_name")]
[ProducesResults(HttpStatusCode.OK)] [ProducesResults(HttpStatusCode.OK)]
public string? GetDisplayName() public string GetDisplayName()
{ {
var user = HttpContext.GetUserOrFail(); var user = HttpContext.GetUserOrFail();
return user.DisplayName; return user.DisplayName ?? "";
} }
[HttpPost("display_name")] [HttpPost("display_name")]