notfire/Iceshrimp.NET
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

[frontend/services] Display error and return empty list without changing state when failing to get emojis

Browse source
This commit is contained in:
pancakes 2025-03-27 01:15:20 +10:00
parent b79de70345
commit 1c7f2832a1
No known key found for this signature in database
1 changed files with 14 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
Iceshrimp.Frontend/Core/Services/EmojiService.cs
View file

@ -1,12 +1,15 @@
using System.Text.Json;
using Iceshrimp.Frontend.Components;
using Iceshrimp.Frontend.Core.Miscellaneous; using Iceshrimp.Frontend.Core.Miscellaneous;
using Iceshrimp.Shared.Schemas.Web; using Iceshrimp.Shared.Schemas.Web;
using Microsoft.AspNetCore.Components; using Microsoft.AspNetCore.Components;
namespace Iceshrimp.Frontend.Core.Services; namespace Iceshrimp.Frontend.Core.Services;
internal class EmojiService(ApiService api) internal class EmojiService(ApiService api, GlobalComponentSvc global)
{ {
[Inject] private ApiService Api { get; set; } = api; [Inject] private ApiService Api { get; set; } = api;
[Inject] private GlobalComponentSvc Global { get; set; } = global;
private List<EmojiResponse>? Emojis { get; set; } private List<EmojiResponse>? Emojis { get; set; }
public async Task<List<EmojiResponse>> GetEmojiAsync() public async Task<List<EmojiResponse>> GetEmojiAsync()
@ -18,10 +21,17 @@ internal class EmojiService(ApiService api)
Emojis = emoji; Emojis = emoji;
return Emojis; return Emojis;
} }
catch (ApiException) catch (ApiException e)
{ {
// FIXME: Implement connection error handling await Global.NoticeDialog?.Display(e.Response.Message ?? "Unable to load emojis",
throw new Exception("Failed to fetch emoji"); NoticeDialog.NoticeType.Error)!;
return [];
}
catch (JsonException)
{
await Global.NoticeDialog?.Display("Emojis provided by the server didn't match what the client expected",
NoticeDialog.NoticeType.Error)!;
return [];
} }
} }
} }