notfire/Iceshrimp.NET
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

[backend/core] Reject like/bookmark/pin/react actions for puree renotes (ISH-167)

Browse source
This commit is contained in:
Laura Hausmann 2024-03-11 02:41:11 +01:00
parent bef11d5cca
commit 12bec02cfd
No known key found for this signature in database
GPG key ID: D044E84C5BE01605
1 changed files with 11 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
Iceshrimp.Backend/Core/Services/NoteService.cs
View file

@ -985,6 +985,9 @@ public class NoteService(
public async Task<bool> LikeNoteAsync(Note note, User user) public async Task<bool> LikeNoteAsync(Note note, User user)
{ {
if (note.IsPureRenote)
throw GracefulException.BadRequest("Cannot like a pure renote");
if (!await db.NoteLikes.AnyAsync(p => p.Note == note && p.User == user)) if (!await db.NoteLikes.AnyAsync(p => p.Note == note && p.User == user))
{ {
var like = new NoteLike var like = new NoteLike
@ -1054,6 +1057,9 @@ public class NoteService(
{ {
if (user.Host != null) throw new Exception("This method is only valid for local users"); if (user.Host != null) throw new Exception("This method is only valid for local users");
if (note.IsPureRenote)
throw GracefulException.BadRequest("Cannot bookmark a pure renote");
if (!await db.NoteBookmarks.AnyAsync(p => p.Note == note && p.User == user)) if (!await db.NoteBookmarks.AnyAsync(p => p.Note == note && p.User == user))
{ {
var bookmark = new NoteBookmark var bookmark = new NoteBookmark
@ -1077,6 +1083,8 @@ public class NoteService(
{ {
if (user.Host != null) throw new Exception("This method is only valid for local users"); if (user.Host != null) throw new Exception("This method is only valid for local users");
if (note.IsPureRenote)
throw GracefulException.BadRequest("Cannot pin a pure renote");
if (note.User != user) if (note.User != user)
throw GracefulException.UnprocessableEntity("Validation failed: Someone else's post cannot be pinned"); throw GracefulException.UnprocessableEntity("Validation failed: Someone else's post cannot be pinned");
@ -1150,6 +1158,9 @@ public class NoteService(
public async Task<string?> ReactToNoteAsync(Note note, User user, string name) public async Task<string?> ReactToNoteAsync(Note note, User user, string name)
{ {
if (note.IsPureRenote)
throw GracefulException.BadRequest("Cannot react to a pure renote");
name = await emojiSvc.ResolveEmojiName(name, user.Host); name = await emojiSvc.ResolveEmojiName(name, user.Host);
if (await db.NoteReactions.AnyAsync(p => p.Note == note && p.User == user && p.Reaction == name)) if (await db.NoteReactions.AnyAsync(p => p.Note == note && p.User == user && p.Reaction == name))
return null; return null;